Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): BatchedParquetReader ignore with_columns #16244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rust): BatchedParquetReader ignore with_columns #16244

wants to merge 1 commit into from

Conversation

cyc4188
Copy link

@cyc4188 cyc4188 commented May 15, 2024

closes #8374

columns are ignored In function ParquetReader::batched.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels May 15, 2024
@ritchie46
Copy link
Member

Thanks! Can you add a test on the python side that ensures we don't regress in the future?

@cyc4188
Copy link
Author

cyc4188 commented May 16, 2024

Thanks! Can you add a test on the python side that ensures we don't regress in the future?

thanks for your feedback!
It seems that BatchedParquetReader is not exposed in the Python API. How can I perform testing on the Python side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego stinodego is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BatchedParquetReader ignores with_columns
2 participants
@cyc4188 @ritchie46