Skip to content

Commit

Permalink
test: fix Go version matrix
Browse files Browse the repository at this point in the history
The matrix didn't really have an effect, all tests ran with the same (default?)
Go version. For example, the "1.17.x, ubuntu-latest" test
https://github.com/kubernetes/klog/runs/5215345316?check_suite_focus=true
for kubernetes#297 complained about functions that
are available in 1.17:

Error: logcheck/pkg/filter_test.go:28:12: undefined: os.WriteFile
Error: logcheck/pkg/filter_test.go:132:14: undefined: os.WriteFile
  • Loading branch information
pohly committed Feb 16, 2022
1 parent 521139a commit 6f34ff9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Expand Up @@ -4,7 +4,7 @@ jobs:
test:
strategy:
matrix:
go-versions: [1.14.x, 1.15.x, 1.16.x, 1.17.x]
go-version: [1.14, 1.15, 1.16, 1.17]
platform: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.platform }}
steps:
Expand Down

0 comments on commit 6f34ff9

Please sign in to comment.