You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Taking a look at the changelog, there are numerous examples of breaking changes, including renaming/moving functions and types, moving existing code to be behind feature flags, removing types, etc.
From the amount of breaking changes and the response in the previous issues, I'm not sure if this problem is being taken seriously. People are using this library in production, and the version is past 1.0, so being this cavalier about breaking changes is a red flag.
This project has been called out for breaking semver before:
1.12.10
to1.12.17
is a breaking change. #146Taking a look at the changelog, there are numerous examples of breaking changes, including renaming/moving functions and types, moving existing code to be behind feature flags, removing types, etc.
From the amount of breaking changes and the response in the previous issues, I'm not sure if this problem is being taken seriously. People are using this library in production, and the version is past 1.0, so being this cavalier about breaking changes is a red flag.
Please follow the guidelines in https://doc.rust-lang.org/cargo/reference/semver.html, https://rust-lang.github.io/rfcs/1105-api-evolution.html, and https://semver.org/spec/v2.0.0.html. The Rust ecosystem relies on people to follow these guidelines to avoid breaking downstream user code (like in the linked issues).
Expected Behavior
Upgrading from 1.0.8 to latest 1.x.x version does not break my code. This is explicitly called out and promised in the changelog:
poem/poem/CHANGELOG.md
Line 5 in a7aad2b
Actual Behavior
There were multiple breaking changes made between minor and even patch versions. This project does not adhere to semantic versioning.
Steps to Reproduce the Problem
See for example the work done in this PR, to upgrade from 1.0.8: pyrossh/rust-embed#173
Specifications
N/A
The text was updated successfully, but these errors were encountered: