Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-semver-checks to CI to ensure semver compliance #379

Open
Christoph-AK opened this issue Aug 30, 2022 · 2 comments
Open

Add cargo-semver-checks to CI to ensure semver compliance #379

Christoph-AK opened this issue Aug 30, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Christoph-AK
Copy link
Contributor

In the past we struggled with SemVer compliance (See #140, #169, #200, #246).

Today I read about cargo-semver-checks (also see the article on Predrags blog.)

Seems like it should be as simple as running the github action. We might want to run it on every tag, and tag all new versions according to the version in the Cargo.toml.

This doesn't entirely fix the problem, but should improve this going forward, especially as there are probably more SemVer-lints coming to the crate.

Might also want to enable http-registry in it once it lands.

@Christoph-AK Christoph-AK added the enhancement New feature or request label Aug 30, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 30, 2022
@Christoph-AK
Copy link
Contributor Author

I still want this. I would work on this if I find the time (if noone did it before, should be a really easy integration), so please leave this open for the time being.

@github-actions github-actions bot removed the Stale label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant