Support signature generation for ActionMailer #270
+213
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
action_mailer
branch
from
5952f14
to
89807eb
Compare
Old minitest depends on mutex_m gem (before v5.21) without explicit dependency. So it causes dependency errors on CI because the mutex_m gem became the bundled gem since Ruby 3.4. This upgrade minitest to the latest version which does not depends on the mutex_m gem.
Since Ruby 3.4, mutex_m gem becames the bundled gem. So it should be listed on the dependencies list. Note: The latest activesupport now does not depends on it. So it's also okay to upgrade it to the new one.
Since Ruby 3.4, abbrev gem has became the bundled gem. But old rbs gem does not depend on it. This updates rbs gem to v3.4, which depends on abbrev gem explicitly.
Since Ruby 3.4, base64, bigdecimal, and drb gems have became the bundled gem. So they should be listed on the dependencies list. Note: The latest activesupport now depends on them. So it's also okay to upgrade it to the new one.
tk0miya
force-pushed
the
action_mailer
branch
from
89807eb
to
87e1322
Compare
ActionMailer automatically generates class methods from the instance methods user defined via method_missing. For example, `AccountMailer.welcome_mail` will be generated from `AccountMail#welcome_mail` that is defined by users. This starts to support signature generation for auto-generated class methods for mailer classes dynamically.
tk0miya
force-pushed
the
action_mailer
branch
from
87e1322
to
135194c
Compare
|
Now rebased on #274 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionMailer automatically generates class methods from the instance methods user defined via method_missing. For example,
AccountMailer.welcome_mailwill be generated fromAccountMail#welcome_mailthat is defined by users.This starts to support signature generation for auto-generated class methods for mailer classes dynamically.