Generate columns aliased by alias_attribute
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Little-Rubyist
force-pushed
the
add_alias_attribute
branch
from
e264994
to
6ac87d2
Compare
Little-Rubyist
commented
Jul 7, 2023
Little-Rubyist
commented
Jul 20, 2023
| mod_sig << "include GeneratedAttributeMethods\n" | ||
| mod_sig << klass.attribute_aliases.map do |col| | ||
| sig = <<~EOS | ||
| alias #{col[0]} #{col[1]} |
There was a problem hiding this comment.
During development, I noticed that each method was defined with the old attribute, even though the name defined in alias_attribute was used in the attribute.
Therefore, we thought it would be better to use alias and made the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.