Support activestorage #195
Conversation
|
gem_rbs_collection with symlink is supported on or after Should I wait for the release of rbs v1.7.0 for this PR? |
| sigs = [] | ||
|
|
||
| # Needs to require "active_storage/engine" | ||
| if klass.respond_to?(:attachment_reflections) |
There was a problem hiding this comment.
attachment_reflections will be defined after "active_storage/engine" is required, and will not be defined if it is not required.
|
|
||
| # Needs to require "active_storage/engine" | ||
| if klass.respond_to?(:attachment_reflections) | ||
| sigs << "module GeneratedAssociationMethods" |
There was a problem hiding this comment.
|
|
||
| if klass.respond_to?(:attachment_reflections) | ||
| klass.attachment_reflections.each do |name, _reflection| | ||
| sigs << "def #{prefix}with_attached_#{name}: () -> #{relation_class_name}" |
There was a problem hiding this comment.
| def build_avatar_blob: (untyped) -> ActiveStorage::Blob | ||
| def create_avatar_blob: (untyped) -> ActiveStorage::Blob | ||
| def create_avatar_blob!: (untyped) -> ActiveStorage::Blob | ||
| def reload_avatar_blob: () -> ActiveStorage::Blob? |
There was a problem hiding this comment.
ksss
force-pushed
the
activestorage
branch
2 times, most recently
from
693b0ea
to
4f21af3
Compare
|
Rebased and use rbs 1.7.0. But I have not been able to solve the CI problem.
CI seems to be down with the following problems. |
|
I resolved CI problem! |
|
I've reverted some commits because they are no longer needed on the master branch. And I've merged master into this PR to check it runs on master branch. |
|
Thank you so much ✨ |
activestorage adds some methods to activerecord model.