Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmarking of npm linked strategy #401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asdfjkalsdfla
Copy link

Adds benchmarks of the new npm linking approach. (I ran into issues with node_modules so disabled that.)

@stackblitz
Copy link

stackblitz bot commented Mar 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@asdfjkalsdfla asdfjkalsdfla temporarily deployed to deploy March 26, 2023 02:39 — with GitHub Actions Inactive
@zkochan
Copy link
Member

zkochan commented Mar 26, 2023

I don't think it is a good idea to add more stuff to these benchmarks. If we add a separate benchmark for npm linked approach, then we should probably add also Yarn's pnpm linker and pnpm's hoisted linker.

The initial goal of these benchmarks was to compare package managers with their default configurations. For Yarn we did an exception because Plug'n'Play doesn't really fit to these benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants