Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update many packages #14

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

update many packages #14

wants to merge 6 commits into from

Conversation

altsalt
Copy link

@altsalt altsalt commented May 9, 2024

After exploring why a package deprecation kept popping up, I followed the thread to this project and noticed that it had been some time since anyone had run pnpm up --latest. I've done that and gotten pnpm test to run without complaint.

Figured there were enough changes to warrant a major semver bump. Unsure if there are other contribution guidelines or suggestions, so opening a PR for review.

Alas the original warning is still popping up, but that's further upstream...

@altsalt
Copy link
Author

altsalt commented May 9, 2024

Note that I finally found (and hopefully fixed) the initial warning that started me down this path in pnpm/pnpm#8068

Also worth noting is that if/when this PR is accepted, https://github.com/pnpm/pnpm/blob/fd6cd2781716dd6c020474beae2f3a3da8493e6b/package.json#L23 will need to be updated to remove the forced Node16 installation (that does not work under NixOS).

@altsalt
Copy link
Author

altsalt commented May 23, 2024

Could you please review this @zkochan ? Don't want to be an annoyance, but would generally like to avoid pulling in so many outdated packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant