Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for gulp-cli v3 in 'SpfxDoctor'. Closes #6045 #6048

Closed
wants to merge 4 commits into from
Closed

Adds support for gulp-cli v3 in 'SpfxDoctor'. Closes #6045 #6048

wants to merge 4 commits into from

Conversation

jasonmokk
Copy link
Contributor

Closes #6045

@jasonmokk
Add support for gulp-cli v3 in 'SpfxDoctor'
28117af 
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Adam-it
Adam-it requested changes May 11, 2024
View reviewed changes
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonmokk gulp-cli@3 is more or less 3 months old. It did not exist when SPFx 1.17 and younger versions were around so we may not guarantee it would work. So we should only apply it for 1.18.0/1/2 and 1.19.0

@Adam-it Adam-it self-assigned this May 11, 2024
@Adam-it Adam-it marked this pull request as draft May 11, 2024 23:43
@jasonmokk
Restrict gulp-cli@3 support to SPFx versions 1.18 and newer
c3d3eb1 
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
@jasonmokk
Copy link
Contributor Author

jasonmokk commented May 12, 2024 •
edited

@Adam-it Got it, thanks for the review. I've updated it to provide gulp-cli@3 support for only SPFx versions 1.18.0 and up.

@jasonmokk jasonmokk requested a review from Adam-it May 12, 2024 00:01
@jasonmokk jasonmokk marked this pull request as ready for review May 12, 2024 00:01
@Adam-it
Copy link
Contributor

Adam-it commented May 12, 2024

@Adam-it Got it, thanks for the review. I've updated it to provide gulp-cli@3 support for only SPFx versions 1.18.0 and up.

Awesome, will review it ASAP.
You Rock 🤩

@waldekmastykarz waldekmastykarz marked this pull request as draft May 13, 2024 08:13
@jasonmokk
Update recommendation
1d508cb 
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
@jasonmokk jasonmokk marked this pull request as ready for review May 13, 2024 15:07
@jasonmokk
Restrict gulp-cli@3 support to SPFx versions 1.19 and newer
f8f0de4 
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
@jasonmokk
Copy link
Contributor Author

jasonmokk commented May 15, 2024 •
edited

Based on the discussion at #6045, I've updated the PR to support gulp-cli@3 for SPFx 1.19.0 only.

@Adam-it
Copy link
Contributor

Adam-it commented May 15, 2024

Based on the discussion at #6045, I've updated the PR to support gulp-cli@3 only for SPFx 1.19.0 and later versions.

Wooow 😮. Your commits are quicker than my review comments. Nice. I was just about to submit a review with this suggestion.
Thanks for the fast update.
We will re-review and merge it ASAP.
You Rock 🤩

Adam-it
Adam-it approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm 🪄
tested locally ✅

image

image

@Adam-it
Copy link
Contributor

Adam-it commented May 16, 2024

Ready to merge 🚀

@Adam-it
Copy link
Contributor

Adam-it commented May 20, 2024 •
edited

Merged manually. You Rock 🤩👏

@Adam-it Adam-it closed this May 20, 2024
@jasonmokk jasonmokk deleted the support-gulp-cli-v3 branch May 20, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

@waldekmastykarz waldekmastykarz Awaiting requested review from waldekmastykarz

Assignees

@Adam-it Adam-it

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'spfx doctor' should support also gulp-cli v3
3 participants
@jasonmokk @Adam-it @waldekmastykarz