Throw error when SP URL is null. Closes #6012 #6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Saurabh7019, we'll review it ASAP! |
waldekmastykarz
requested changes
May 15, 2024
src/utils/validation.ts
Outdated
| if (!url) { | ||
| return false; | ||
| if (typeof url !== 'string') { | ||
| return 'URL must be a string'; |
There was a problem hiding this comment.
To keep it more in line with the other error, I suggest that we rephrase it a bit to "SharePoint Online site URL must be a string."
Also, let's end the error message with a period.
For the other error that is already there, could we add a period there as well? And maybe let's encapsulate the url value with single quotes to make it clearer.
milanholemans
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6012