Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command: viva engage community add. Closes #5753 #5976

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

New command: viva engage community add. Closes #5753 #5976

wants to merge 1 commit into from

Conversation

Saurabh7019
Copy link
Contributor

Closes #5753

@Saurabh7019 Saurabh7019 force-pushed the issue-5753 branch 2 times, most recently from 1adba09 to a1eb1c4 Compare April 11, 2024 13:34
@Saurabh7019 Saurabh7019 marked this pull request as ready for review April 11, 2024 13:38
@milanholemans
Copy link
Contributor

Thank you @Saurabh7019, we'll try to review it ASAP!

@Saurabh7019
Copy link
Contributor Author

Hi @milanholemans,

The CSV output of the command with the --wait flag is empty. I found that this issue resolves when directly importing csv-stringify/sync instead of using dynamic import within the getCsvOutput method.

I have not made any changes to the getCsvOutput method as part of this PR, as I think it requires should be handled separately and undergo regression testing.

@milanholemans
Copy link
Contributor

Hi @Saurabh7019, strange behavior, I haven't had the time yet to look into it and test it out, but at first sight, I saw that you are logging messages without awaiting them. Writing logs are promises that should be awaited, maybe this fixes the issue?

@Saurabh7019
Copy link
Contributor Author

Hi @Saurabh7019, strange behavior, I haven't had the time yet to look into it and test it out, but at first sight, I saw that you are logging messages without awaiting them. Writing logs are promises that should be awaited, maybe this fixes the issue?

That should indeed fix the issue. Thanks for the quick help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: viva engage community add
2 participants
@Saurabh7019 @milanholemans