Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades dependency xmldom #2900

Closed
wants to merge 2 commits into from
Closed

Upgrades dependency xmldom #2900

wants to merge 2 commits into from

Commits on Dec 29, 2021

  1. Upgrades dependency xmldom 

    Switching from package `xmldom` to `@xmldom/xmldom`, which resolves the security issue present in latest xmldom version 0.6.0:
GHSA-5fg8-2547-mr8q

The reason is that the maintainers were forced to switch to a scoped package since 0.7.0:
 xmldom/xmldom#271

- The reference to `@types/xmldom` can be dropped, since xmldom now comes with types as part of the package.
- I used node 16 to run `npm install` which updated the npm-shrinkwrap.json.
- I didn't attempt to run the project on my machine, but I'm hoping for the CI checks to cover the important things.
- The package `adaptive-expressions` has a dependency to `@xmldom/xmldom@0.7.5`, so if you prefer I can also change the PR to point to that version in the package.json.
  I didn't find any tools that support this project in keeping dependencies up to date, so I'm not sure which way you would prefer.

I'm one of the xmldom maintainers. Don't hesitate to ask me questions.
    @karfau
    karfau committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    b86ffdf View commit details
    Browse the repository at this point in the history

  2. Downgrade xmldom to 0.7.5 

    due to failing tests

#2900 (comment)
    @karfau
    karfau committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    6fbb790 View commit details
    Browse the repository at this point in the history