New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for gulp-cli v3 in 'SpfxDoctor'. Closes #6045 #6048
Conversation
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonmokk gulp-cli@3 is more or less 3 months old. It did not exist when SPFx 1.17 and younger versions were around so we may not guarantee it would work. So we should only apply it for 1.18.0/1/2 and 1.19.0
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
@Adam-it Got it, thanks for the review. I've updated it to provide gulp-cli@3 support for only SPFx versions 1.18.0 and up. |
Awesome, will review it ASAP. |
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Based on the discussion at #6045, I've updated the PR to support gulp-cli@3 for SPFx 1.19.0 only. |
Wooow 😮. Your commits are quicker than my review comments. Nice. I was just about to submit a review with this suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge 🚀 |
Merged manually. You Rock 🤩👏 |
Closes #6045