New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'spfx doctor' should support also gulp-cli v3 #6045
Comments
Hello, I would like to work on this issue. Can you please assign it to me? |
Definitely @jasonmokk, all yours! |
@Adam-it, did you also learn starting from which version SPFx supports gulp-cli@3? |
From when it was released. So 3 months ago so the first version is 1.18 no sooner |
I suggest that we don't make assumptions and instead check with Alex |
sure thing. I pinged Alex. Will keep you updated 👍 |
@waldekmastykarz after rediscussing this topic with Alex and rechecking it myself we agreed it's best to add gulp-cli@3 only for SPFx 1.19.0 and later versions. |
Thank you for confirming @Adam-it |
So it seems currently in
spfx doctor
we validate ifgulp-cli
is either v1 or v2if we check the spfx docs we will see the guide will actually install the latest
gulp-cli
which is v3From what I checked SPFx should work properly with gulp-cli@3 and I got it confirmed from Alex as well.
Lets add this support
The text was updated successfully, but these errors were encountered: