Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'spfx doctor' should support also gulp-cli v3 #6045

Closed
Adam-it opened this issue May 10, 2024 · 8 comments
Closed

'spfx doctor' should support also gulp-cli v3 #6045

Adam-it opened this issue May 10, 2024 · 8 comments

Comments

@Adam-it
Copy link
Contributor

Adam-it commented May 10, 2024

So it seems currently in spfx doctor we validate if gulp-cli is either v1 or v2

image

if we check the spfx docs we will see the guide will actually install the latest gulp-cli which is v3

image

From what I checked SPFx should work properly with gulp-cli@3 and I got it confirmed from Alex as well.

Lets add this support

@jasonmokk
Copy link
Contributor

Hello, I would like to work on this issue. Can you please assign it to me?

@milanholemans
Copy link
Contributor

Definitely @jasonmokk, all yours!

@waldekmastykarz
Copy link
Member

@Adam-it, did you also learn starting from which version SPFx supports gulp-cli@3?

@Adam-it
Copy link
Contributor Author

Adam-it commented May 13, 2024

@Adam-it, did you also learn starting from which version SPFx supports gulp-cli@3?

From when it was released. So 3 months ago so the first version is 1.18 no sooner

@waldekmastykarz
Copy link
Member

waldekmastykarz commented May 14, 2024

@Adam-it, did you also learn starting from which version SPFx supports gulp-cli@3?

From when it was released. So 3 months ago so the first version is 1.18 no sooner

I suggest that we don't make assumptions and instead check with Alex

@Adam-it
Copy link
Contributor Author

Adam-it commented May 15, 2024

sure thing. I pinged Alex. Will keep you updated 👍

@Adam-it
Copy link
Contributor Author

Adam-it commented May 15, 2024

@waldekmastykarz after rediscussing this topic with Alex and rechecking it myself we agreed it's best to add gulp-cli@3 only for SPFx 1.19.0 and later versions.

@waldekmastykarz
Copy link
Member

Thank you for confirming @Adam-it

@Adam-it Adam-it added this to the v7.9 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants