Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix codesandbox build #293

Merged
merged 1 commit into from Jul 24, 2023

Conversation

saitonakamura
Copy link
Sponsor Collaborator

@saitonakamura saitonakamura commented Jul 23, 2023

Hey, @CodyJasonBennett , I saw that you've brought back path resolve in examples/vite.config.ts. I removed it on purpose so the codesandbox CI would work (it used to, but now it doesn't, not sure why). My idea is that examples are supposed to be run from the root with yarn dev, not from examples folder, and I highlighted it in https://github.com/pmndrs/react-xr/blob/master/CONTRIBUTING.md#run-locally for the newcomers. I apologize for not being clear enough in my PRs.

So, like, root vite.config will be responsible for local runs and examples/vite.config will be for codesandbox CI.

Example of codesandbox not working may be found in this PR, for instance
#294
https://codesandbox.io/p/sandbox/examples-j88rj5

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c52cb97:

Sandbox Source
examples Configuration

@saitonakamura
Copy link
Sponsor Collaborator Author

Hey @CodyJasonBennett , are you ok with this ^ ?

@CodyJasonBennett CodyJasonBennett merged commit d6acce1 into master Jul 24, 2023
2 checks passed
@saitonakamura saitonakamura deleted the fix/examples-codesandbox-ci branch July 25, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants