fix(examples): fix codesandbox build #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @CodyJasonBennett , I saw that you've brought back path resolve in
examples/vite.config.ts
. I removed it on purpose so the codesandbox CI would work (it used to, but now it doesn't, not sure why). My idea is that examples are supposed to be run from the root withyarn dev
, not fromexamples
folder, and I highlighted it in https://github.com/pmndrs/react-xr/blob/master/CONTRIBUTING.md#run-locally for the newcomers. I apologize for not being clear enough in my PRs.So, like, root vite.config will be responsible for local runs and examples/vite.config will be for codesandbox CI.
Example of codesandbox not working may be found in this PR, for instance
#294
https://codesandbox.io/p/sandbox/examples-j88rj5