Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9] fix(useLoader): properly infer Loader types #2723

Merged
merged 12 commits into from
Jun 22, 2023
Merged

[v9] fix(useLoader): properly infer Loader types #2723

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1b602d4
fix(types): loosen Loader type
CodyJasonBennett Jan 19, 2023
7edff25
fix(types): accept string[][] in useLoader
CodyJasonBennett Feb 27, 2023
8ee196d
Merge branch 'v9' into fix/loosen-loader-type
CodyJasonBennett Feb 27, 2023
b255c2a
fix(types): remove excess useLoader generics
CodyJasonBennett Feb 27, 2023
f750f3a
chore(hooks): cleanup
CodyJasonBennett Feb 27, 2023
0340acd
chore(types): more cleanup, update snapshot
CodyJasonBennett Feb 27, 2023
0fc6afc
refactor(hooks): try to infer useLoader type
CodyJasonBennett Feb 27, 2023
9c5d23a
chore(hooks): prune unused types
CodyJasonBennett Feb 27, 2023
f479040
Merge branch 'v9' into fix/loosen-loader-type
CodyJasonBennett Feb 27, 2023
0d53ce9
fix(hooks): Loader#load signature returns any
CodyJasonBennett Feb 27, 2023
2847837
fix(hooks): remove Loader#loadAsync
CodyJasonBennett Feb 27, 2023
b22c406
fix: harden hooks tests
CodyJasonBennett Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/fiber/src/core/hooks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import type { Instance } from './reconciler'

export interface Loader<T> extends THREE.Loader {
load(
url: string,
onLoad?: (result: T) => void,
url: string | string[],
onLoad?: (result: T, ...args: any[]) => void,
CodyJasonBennett marked this conversation as resolved.
Show resolved Hide resolved
onProgress?: (event: ProgressEvent) => void,
onError?: (event: ErrorEvent) => void,
): unknown
Expand Down