Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully wrap context in production #2534

Merged
merged 1 commit into from Sep 27, 2022
Merged

Conversation

CodyJasonBennett
Copy link
Member

Fixes #2533. Dev-only fields were incorrectly overwritten in production. Mirrors pmndrs/its-fine#15.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6022b9c:

Sandbox Source
example Configuration

@CodyJasonBennett CodyJasonBennett merged commit 2940453 into master Sep 27, 2022
@CodyJasonBennett CodyJasonBennett deleted the fix/upgrade-deps branch September 27, 2022 11:11
@CodyJasonBennett CodyJasonBennett changed the title fix: upgrade deps fix: gracefully wrap context in production Sep 27, 2022
renovate bot added a commit to ziyadedher/ziyadedher that referenced this pull request Sep 27, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.8.4` ->
`8.8.6`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.8.4/8.8.6)
|
[![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.6/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.6/compatibility-slim/8.8.4)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.6/confidence-slim/8.8.4)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber</summary>

###
[`v8.8.6`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.8.6)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.8.5...v8.8.6)

#### What's Changed

- fix: gracefully wrap context in production by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2534

**Full Changelog**:
pmndrs/react-three-fiber@v8.8.5...v8.8.6

###
[`v8.8.5`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.8.5)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.8.4...v8.8.5)

#### What's Changed

- fix: upgrade deps to work-around CRA by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2531

**Full Changelog**:
pmndrs/react-three-fiber@v8.8.4...v8.8.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDQuNSIsInVwZGF0ZWRJblZlciI6IjMyLjIwNi4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ziyadedher pushed a commit to ziyadedher/ziyadedher that referenced this pull request Dec 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.8.4` ->
`8.8.6`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.8.4/8.8.6)
|
[![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.6/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.6/compatibility-slim/8.8.4)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.6/confidence-slim/8.8.4)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber</summary>

###
[`v8.8.6`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.8.6)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.8.5...v8.8.6)

#### What's Changed

- fix: gracefully wrap context in production by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2534

**Full Changelog**:
pmndrs/react-three-fiber@v8.8.5...v8.8.6

###
[`v8.8.5`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.8.5)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.8.4...v8.8.5)

#### What's Changed

- fix: upgrade deps to work-around CRA by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#2531

**Full Changelog**:
pmndrs/react-three-fiber@v8.8.4...v8.8.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDQuNSIsInVwZGF0ZWRJblZlciI6IjMyLjIwNi4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot redefine property: _currentRenderer
1 participant