Skip to content

Official support for React18 incl StrictMode #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 4, 2022
Merged

Conversation

joshuaellis
Copy link
Member

Why

What

  • Updates peer deps to allow react@18
  • Move the cleanup handling into an actual effect cleanup operation in withAnimated
  • Fix useForceUpdate by using arbitrary number to update state because an empty object does not work (in strict mode)
  • Check if there are used transitions to be ran in initial mount (would only have an effect in the instance of strict mode) in useTransition

Checklist

  • Ready to be merged

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
react & testing

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
should run usedTransitions when the component is mounted
@vercel
Copy link

vercel bot commented Apr 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-spring-io ✅ Ready (Inspect) Visit Preview May 4, 2022 at 3:01PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f3f11ba:

Sandbox Source
spring-animating-auto Configuration
spring-card Configuration
spring-cards-stack Configuration
pmndrs/react-spring Configuration
spring-draggable-list Configuration
spring-flip-card Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
charming-water-5bf0ns Issue #1828
reverent-blackwell-bs8jit Issue #1828

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
resolves #1883

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment