Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): properly update atom values with edge-case dependency #2555

Merged
merged 3 commits into from
May 21, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented May 15, 2024

Related Issues or Discussions

Fixes #2554

Summary

It seems a regression with #2396.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:08pm

Copy link

codesandbox-ci bot commented May 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented May 15, 2024

Size Change: +37 B (+0.04%)

Total Size: 91.7 kB

Filename Size Change
dist/system/vanilla.development.js 4.35 kB +8 B (+0.18%)
dist/system/vanilla.production.js 2.2 kB +7 B (+0.32%)
dist/umd/vanilla.development.js 5.21 kB +8 B (+0.15%)
dist/umd/vanilla.production.js 2.8 kB +6 B (+0.21%)
dist/vanilla.js 5.11 kB +8 B (+0.16%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 927 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.4 kB
dist/experimental.js 4.72 kB
dist/index.js 242 B
dist/react.js 1.06 kB
dist/react/utils.js 1.4 kB
dist/system/babel/plugin-debug-label.development.js 1.1 kB
dist/system/babel/plugin-debug-label.production.js 771 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.58 kB
dist/system/babel/preset.production.js 1.14 kB
dist/system/experimental.development.js 3.84 kB
dist/system/experimental.production.js 2.04 kB
dist/system/index.development.js 253 B
dist/system/index.production.js 182 B
dist/system/react.development.js 1.18 kB
dist/system/react.production.js 711 B
dist/system/react/utils.development.js 860 B
dist/system/react/utils.production.js 461 B
dist/system/utils.development.js 258 B
dist/system/utils.production.js 188 B
dist/system/vanilla/utils.development.js 5.08 kB
dist/system/vanilla/utils.production.js 3.07 kB
dist/umd/babel/plugin-debug-label.development.js 1.08 kB
dist/umd/babel/plugin-debug-label.production.js 855 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.54 kB
dist/umd/babel/preset.production.js 1.22 kB
dist/umd/experimental.development.js 4.81 kB
dist/umd/experimental.production.js 2.69 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.54 kB
dist/umd/react/utils.production.js 1.02 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla/utils.development.js 5.98 kB
dist/umd/vanilla/utils.production.js 3.7 kB
dist/utils.js 246 B
dist/vanilla/utils.js 5.85 kB

compressed-size-action

Copy link

github-actions bot commented May 15, 2024

LiveCodes Preview in LiveCodes

Latest commit: 28b5a93
Last updated: May 21, 2024 11:06pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/FXYN88344

See documentations for usage instructions.

@dai-shi dai-shi changed the title add a failing test for #2554 fix(store): properly update atom values with edge-case dependency May 15, 2024
@dai-shi dai-shi marked this pull request as ready for review May 15, 2024 02:24
@dai-shi dai-shi added this to the v2.8.1 milestone May 15, 2024
@dai-shi dai-shi merged commit 284bd21 into main May 21, 2024
37 checks passed
@dai-shi dai-shi deleted the fix/bug-2554 branch May 21, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant