docs: Correct error in PerformanceMonitor example snippet #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected example which was passing a second parameter to Math.round() which only takes one parameter.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected example which was passing a second parameter to Math.floor() which only takes one parameter.
Why
The code in the documentation is incorrect.
Math.floor()only takes in one element. This change corrects the error and modifies the logic to work without error.What
Documentation was corrected - and follows the documentation hosted here: https://docs.pmnd.rs/react-three-fiber/advanced/scaling-performance. However, the documentation there has a dependancy on lodash - this change does not introduce the dependancy but rather manually applies the calculation to round to a precision of 1 digit after the decimal.
Checklist