fix: add thresholdOffset for infinite scrolling
#1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab345fa:
|
nhtoby311
changed the title
thresholdOffset for infinite scrolling
|
but this would require knowledge around these edge cases and magic numbers deployed in user land. 😕 did you find any more info on why these platforms never reach the threshold? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Regarding this bug #1615, on some device and browser combination, the scroll does not reach the
scrollThreshold, therefore, it does not reset the scroll bar back to top, and results in broken infinite scroll effect.What
I simply add a props name
thresholdOffsetto offset thisscrollThreshold.Could not identify the reason why the calculation of current scroll position is off by ~0.44 in my test using Samsung A53 with Chrome, as it varied between device and browser. However, I think this solution at least give us the option to tackle these edge cases.
Checklist