Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(View): wrap portal in fragment #1074

Merged
merged 1 commit into from Oct 4, 2022
Merged

Conversation

CodyJasonBennett
Copy link
Member

@CodyJasonBennett CodyJasonBennett commented Oct 4, 2022

Fixes #1059 by wrapping the inner portal inside of a fragment. This comes from a typing issue in R3F's createPortal, fixing this downstream in pmndrs/react-three-fiber#2550.

@vercel
Copy link

vercel bot commented Oct 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drei ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 0:19AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd65783:

Sandbox Source
quirky-shape-bb3w5d Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

🎉 This PR is included in version 9.32.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View' cannot be used as a JSX component. Its return type 'ReactNode' is not a valid JSX element.
1 participant