useHelper - dispose helpers (#1149)

Dispose helper on destroy
pmndrs · Nov 21, 2022 · b0ce751 · b0ce751
1 parent b47417b
commit b0ce751
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/core/useHelper.tsx b/src/core/useHelper.tsx
@@ -32,11 +32,17 @@ export function useHelper<T extends Constructor>(
      */
     if (!object3D && helper.current) {
       scene.remove(helper.current)
+      if(helper.current?.dispose) {
+        helper.current.dispose()
+      }
     }
 
     return () => {
       if (helper.current) {
         scene.remove(helper.current)
+        if(helper.current?.dispose) {
+          helper.current.dispose()
+        }
       }
     }
   }, [scene, helperConstructor, object3D, ...args])