Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test Node 18 and remove debug console #631

Merged
merged 3 commits into from May 23, 2022
Merged

chore: test Node 18 and remove debug console #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8884ac4
ci: test on node 18
pmmmwh Apr 25, 2022
2eb6cbc
chore: use node.js 18.2
pmmmwh May 21, 2022
9ebd581
fix: remove debug console.log
pmmmwh May 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -4,14 +4,14 @@ anchors:
- &node-version-enum
- '12.22'
- '14.19'
- '16.13'
- '17.4'
- '16.14'
- '18.2'
- &webpack-version-enum
- '4'
- '5'
- &node-version-param
node-version:
default: '16.13'
default: '16.14'
enum: *node-version-enum
type: enum
- &webpack-version-param
Expand Down
1 change: 0 additions & 1 deletion sockets/utils/getSocketUrlParts.js
View file
Open in desktop
Expand Up @@ -117,7 +117,6 @@ function getSocketUrlParts(resourceQuery, metadata) {
}

if (!urlParts.hostname || !urlParts.pathname) {
console.log(urlParts);
throw new Error(
[
'[React Refresh] Failed to get an URL for the socket connection.',
Expand Down