fix: handle WDS auto port values (#574)

pmmmwh · Feb 6, 2022 · 7b828a5 · 7b828a5
1 parent 64eba28
commit 7b828a5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/utils/getAdditionalEntries.js b/lib/utils/getAdditionalEntries.js
@@ -45,7 +45,7 @@ function getAdditionalEntries({ devServer, options }) {
         path = parsedUrl.pathname;
       }
       if (parsedUrl.port != null) {
-        port = String(parsedUrl.port) !== '0' ? parsedUrl.port : undefined;
+        port = !['0', 'auto'].includes(String(parsedUrl.port)) ? parsedUrl.port : undefined;
       }
       if (parsedUrl.protocol != null) {
         protocol = parsedUrl.protocol !== 'auto' ? parsedUrl.protocol.replace(':', '') : 'ws';

diff --git a/test/unit/getAdditionalEntries.test.js b/test/unit/getAdditionalEntries.test.js
@@ -196,6 +196,24 @@ describe('getAdditionalEntries', () => {
       prependEntries: [ReactRefreshEntry],
       overlayEntries: [`${ErrorOverlayEntry}?sockHost=0.0.0.0&sockPath=/socket&sockProtocol=ws`],
     });
+    expect(
+      getAdditionalEntries({
+        options: DEFAULT_OPTIONS,
+        devServer: {
+          client: {
+            webSocketURL: {
+              hostname: '0.0.0.0',
+              pathname: '/socket',
+              protocol: 'auto',
+              port: 'auto',
+            },
+          },
+        },
+      })
+    ).toStrictEqual({
+      prependEntries: [ReactRefreshEntry],
+      overlayEntries: [`${ErrorOverlayEntry}?sockHost=0.0.0.0&sockPath=/socket&sockProtocol=ws`],
+    });
   });
 
   it('should handle devServer client.webSocketURL missing values', () => {