-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Fix #4990 - Add attribute @PackageQualifier
to ASTClassType
#5005
[java] Fix #4990 - Add attribute @PackageQualifier
to ASTClassType
#5005
Conversation
Generated by 🚫 Danger |
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTClassType.java
Outdated
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTClassType.java
Show resolved
Hide resolved
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/ast/GitHubBug207.txt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we should add an explicit test to verify the use case, that this change is supposed to fix. You can use the code snippet from #4946 and verify that that PackageQualifier has the expected values (the package name). In most tests I've seen here, we expect "null"....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Describe the PR
Related issues
Ready?
./mvnw clean verify
passes (checked automatically by github actions)