Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apex] ApexUnitTestClassShouldHaveAssertsRule: Support new Assert class (Apex v56.0) #4097

Merged
merged 20 commits into from Aug 29, 2022
Merged

[apex] ApexUnitTestClassShouldHaveAssertsRule: Support new Assert class (Apex v56.0) #4097

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
237b106
Add new assert methods for api 56
tprouvot Aug 17, 2022
2e1d913
Update @tprouvot as a contributor
tprouvot Aug 18, 2022
2edcfe2
Update @tprouvot as a contributor
tprouvot Aug 18, 2022
539838c
Update previous negative test which is ok now and add new positive test.
tprouvot Aug 18, 2022
ad21a24
Fix contributors
tprouvot Aug 18, 2022
a2058c4
move fully qualified variant under comment (PR Comment)
tprouvot Aug 18, 2022
dc03e52
Update method name and number of parameters (PR Comment)
tprouvot Aug 18, 2022
4180286
fix contributors
tprouvot Aug 18, 2022
e0b9965
Update pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/best…
tprouvot Aug 25, 2022
d5098ca
Update pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule…
tprouvot Aug 25, 2022
50641a5
Fix typo
tprouvot Aug 25, 2022
2e9f25c
PR review comment
tprouvot Aug 25, 2022
c61108c
Add new Assert methods to ApexAssertionsShouldIncludeMessageRule
tprouvot Aug 25, 2022
d7cf959
Merge branch 'pmd:master' into feature/addNewClassForAssertion
tprouvot Aug 25, 2022
46aa491
Merge branch 'feature/addNewClassForAssertion' of https://github.com/…
tprouvot Aug 25, 2022
d6194be
Add tests for new methods
tprouvot Aug 25, 2022
ac94df9
Update add violation parameters to macth with new tests
tprouvot Aug 25, 2022
065b4b8
Remove param message not mandatory in this test
tprouvot Aug 25, 2022
d73cdcc
Ad new tests for Assert method class
tprouvot Aug 25, 2022
29c4e99
Increase test coverage
tprouvot Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...t/sourceforge/pmd/lang/apex/rule/bestpractices/xml/ApexUnitTestClassShouldHaveAsserts.xml
View file
Open in desktop
Expand Up @@ -102,8 +102,8 @@ public class Foo {
<code><![CDATA[
@isTest
public class Foo {
public static testMethod void testAssertIsTrue() {
Assert.assertEquals(someCondition);
public static testMethod void testAssertEqual() {
Assert.assertEquals(null, someCondition);
tprouvot marked this conversation as resolved.
Show resolved Hide resolved
}

public static testMethod void testLocalVerify() {
Expand Down