Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix #3697 - lookahead error in concise resource spec #3774

Merged
merged 2 commits into from Feb 19, 2022

Conversation

oowekyala
Copy link
Member

Describe the PR

The LOOKAHEAD(2) was not enough as f.in may begin a qualified type of a local var-ish resource, or a concise resource.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 6.43.0 milestone Feb 11, 2022
@pmd-test
Copy link

1 Message
📖 This changeset changes 87 violations,
introduces 1 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel self-requested a review February 13, 2022 18:32
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel
Copy link
Member

adangel commented Feb 19, 2022

I wonder, what the problem is with the file AutowiredAnnotationBeanPostProcessor.java during regression testing - this almost always shows up as changed. The baseline somehow seems to use a changed version of this file?? I think only the line numbers are different....

@adangel adangel merged commit b6dae35 into pmd:master Feb 19, 2022
@oowekyala oowekyala deleted the issue3697-parse-twr branch February 19, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] Parsing error with try-with-resources and qualified resource
3 participants