Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #3403 about MethodNamingConventions and JUnit5 parameterized tests #3445

Merged
merged 3 commits into from
Aug 7, 2021
Merged

[java] Fix #3403 about MethodNamingConventions and JUnit5 parameterized tests #3445

merged 3 commits into from
Aug 7, 2021

Conversation

CyrilSicard
Copy link
Contributor

@CyrilSicard CyrilSicard commented Aug 6, 2021 •
edited

Describe the PR

  • Consider parameterized JUnit5 tests for methodNaming Conventions ;
  • Already fixed for PMD 7.0.0 but with no release date, I hope that this can be useful for PMD 6.x.x ;)

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@CyrilSicard CyrilSicard marked this pull request as ready for review August 6, 2021 12:57
@pmd-test
Copy link

pmd-test commented Aug 7, 2021

1 Message
📖 This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

oowekyala
oowekyala approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@oowekyala oowekyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks :)

@oowekyala oowekyala added this to the 6.38.0 milestone Aug 7, 2021
@oowekyala oowekyala self-assigned this Aug 7, 2021
oowekyala added a commit that referenced this pull request Aug 7, 2021
@oowekyala
Update release notes, refs #3445
e72d79d
@oowekyala oowekyala merged commit 8153ce9 into pmd:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowekyala oowekyala oowekyala approved these changes

Assignees

@oowekyala oowekyala

Labels
None yet
Projects
None yet
Milestone
6.38.0
Development

Successfully merging this pull request may close these issues.

[java] MethodNamingConventions junit5TestPattern does not detect parameterized tests
3 participants
@CyrilSicard @pmd-test @oowekyala