Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call setsid() in ProxyCommand subprocess #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ploxiln
Copy link
Owner

@ploxiln ploxiln commented Mar 28, 2020

so that signals sent to the foreground process group
are not also received by the ProxyCommand
(it should be closed by the transport when the parent shuts down)

inspired by paramiko#1183

@ploxiln
Copy link
Owner Author

ploxiln commented Jul 21, 2020

I think this will need to be avoided on windows where setsid() is not available.

so that signals sent to the foreground process group
are not also received by the ProxyCommand
(it should be closed by the transport when the parent shuts down)

inspired by paramiko#1183
@ploxiln
Copy link
Owner Author

ploxiln commented Nov 27, 2021

I'm now thinking that maybe this should be optional anyway, maybe not all ProxyCommands should use setsid(). Also, since Python-3.2:

if start_new_session is true the setsid() system call will be made in the child process prior to the execution of the subprocess. (POSIX only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant