Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for rsa-sha2 signatures #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add support for rsa-sha2 signatures #149

wants to merge 2 commits into from

Conversation

ploxiln
Copy link
Owner

@ploxiln ploxiln commented Feb 23, 2023

Add support for rsa-sha2-256 and rsa-sha2-512, as well as the ext-info / server-sig-algs in handshake, used to advertise support for these new signature types.

I don't want to just copy exactly how it was handled in upstream paramiko, because if it doesn't get the ext-info message it assumes the new signature types for rsa keys are supported, rather than the inverse.

I've stalled out some months ago, because I've run into some buggyness ... and this is actually pretty tricky and messy to implement in this codebase, and my motivation ran out 馃し

References I'm working from:

Existing ssh-rsa keys can be used with sha2-256 or sha2-512
signatures instead of traditional sha1: RFC-8332

Add support for extention negotiation to discover support for the
new rsa signature types: MSG_EXT_INFO / server-sig-algs: RFC-8308

Ported from upstream Paramiko to Paramiko-NG and trimmed:
Co-Authored-By: Pierce Lopez <pierce.lopez@gmail.com>
@ploxiln ploxiln added the wip work in progress label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants