tests: sftp listdir under a locale with non-ascii date strings #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
test_listdir_locale
branch
from
81ddf4a
to
d2cb456
Compare
This demonstrates failure under python-2.7, because SFTPAttributes uses the locale-aware %b directive for the abbreviated month name with time.strftime(), and it is not decoded correctly with python-2.7. Instead of fixing for python-2.7 in paramiko-ng, we'll just wait until python2 support is removed before merging in this test case. This test code was so old, it needed multiple rounds of updates and cleanups by multiple contributors: Co-Authored-By: Jeff Forcier <jeff@bitprophet.org> Co-Authored-By: Stanislav Levin <slev@altlinux.org>
and move apt package install to its own section
ploxiln
force-pushed
the
test_listdir_locale
branch
from
d2cb456
to
93a3b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates failure under python-2.7, because SFTPAttributes
uses the locale-aware %b directive for the abbreviated month name
with time.strftime(), and it is not decoded correctly with python-2.7.
Instead of fixing for python-2.7 in paramiko-ng, we'll just wait
until python2 support is removed before merging in this test case.
This test code was so old, it needed multiple rounds of updates
and cleanups by multiple contributors:
Co-Authored-By: Jeff Forcier jeff@bitprophet.org
Co-Authored-By: Stanislav Levin slev@altlinux.org