-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Table
trace.
#165
base: main
Are you sure you want to change the base?
Add Table
trace.
#165
Conversation
Really great to see a Table Trace in the pipeline. Would also love to see a Pie Chart Trace if possible. Would love to contribute this, but don't have the requisite skill to do it yet. |
This is also first time I make a pr in plotly, after this pr is merged, I would like to make a similar Pie Chart pr. |
Hi @igiagkiozis, would be great to have this pull request approved in your next release. I tried it out and it works quite well. I also find it to be a very useful feature. |
@baiguoname I'm glad someone started work on this! |
Thanks very much, I think it's great. Excuse me, I'm still new to github, what should I do next? Should I close this commit, and you pull a new pr to this crate? |
Sorry for the late reply, I swear github never notifies me of anything. |
] | ||
); | ||
let mut plot = Plot::new(); | ||
plot.add_trace(table_trace); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baiguoname There is a typo here. This should be trace
Tables now take a header and cells struct
@baiguoname hi, is this feature still able to be merged? Really looking forward to see it. |
#148
This issue mentioned the trace.