Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add From<String> impl for Title #154

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add From<String> impl for Title #154

wants to merge 5 commits into from

Conversation

fsktom
Copy link

@fsktom fsktom commented Jul 27, 2023

A small quality of life improvement

So that instead of doing

let layout = Layout::new().title(format!("<b>{title}</b>").as_str().into());

I can now do

let layout = Layout::new().title(format!("<b>{title}</b>").into());

@fsktom
Copy link
Author

fsktom commented Aug 8, 2023

This is even better! Thanks @mfreeborn :)

 let layout = Layout::new().title(format!("<b>{title}</b>"));

is even cleaner now :D

@fsktom
Copy link
Author

fsktom commented Aug 8, 2023

I'm going to go ahead and try to fix the failing examples etc. if that's alright with you

@mfreeborn
Copy link
Contributor

mfreeborn commented Aug 8, 2023 via email

@fsktom
Copy link
Author

fsktom commented Aug 9, 2023

@mfreeborn I tried improving LegendGroupTitle similarly to Title in 3feaa0c
Seemed to work fine, but I'm not sure if I did everything correctly

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants