Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scaling of SVG exports by not adding vector-effect to static plots #6445

Merged
merged 3 commits into from Jan 24, 2023
Merged

Fix scaling of SVG exports by not adding vector-effect to static plots #6445

merged 3 commits into from Jan 24, 2023

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 24, 2023

As discovered by @nicolaskruchten.
@plotly/plotly_js

alexcjohnson
alexcjohnson approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Well done!

Always makes me a little nervous when baselines change but I can't see what changed. Seems OK though, the renderer must have some slightly different optimizations with or without vector-effect.

@archmoj
Copy link
Contributor Author

archmoj commented Jan 24, 2023

For reference, here is the diff:
diff-17
diff-28
diff-line_scatter

@archmoj archmoj merged commit 51e7512 into master Jan 24, 2023
@archmoj archmoj deleted the no-vector-effect-static-plot branch January 24, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@archmoj @alexcjohnson