Mult axis formatting #6334
Mult axis formatting #6334
Conversation
|
@archmoj - I'm still struggling to figure out how the mock validation is failing here with the error: I've added the |
test/plot-schema.json
Outdated
| @@ -10735,6 +10735,12 @@ | |||
| "editType": "ticks", | |||
| "valType": "boolean" | |||
| }, | |||
| "shift": { | |||
There was a problem hiding this comment.
This one appears to be on the xaxis.
Yet we are not going to implement this feature for the x axes in this PR.
If that's the case, let's make the adjustments in the attribute file so that it would only be added to the yaxis .
Thanks!
There was a problem hiding this comment.
💃 Fantastic. Great work @hannahker in a really tricky part of our code! Only remaining piece that I see is getting the new attrs out of the x axis schema - and I suppose adding a changelog entry.
|
Great work! Thanks @hannahker 🎖️ 🏅 🥇 🏆 🙏 for the contribution! |
Work in progress changes to enable automatic formatting of multiple y axes on plots. In rough order of priority, to dos include:
ax._shifts are set correctlyconfig: {scrollZoom: true}zerolineshiftis given a numerical inputyaxis.shift=true(mock validation and bundle jasmine)yaxis.shift=true, set default position according to domain of counter axisshowline=true)shiftvalue based on axes of the sameoverlayinggroupshiftvalue in cases with multiple axesFix overlap with legend[out of scope - separate PR]Automargin correctly with subplot columns[out of scope - will not be addressed]