Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include gl3d in strict bundle #5888

Merged
merged 51 commits into from Sep 2, 2021
Merged

Include gl3d in strict bundle #5888

merged 51 commits into from Sep 2, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 12, 2021

Addresses #897 and adds all gl3d traces as well as heatmapgl and pointcloud traces from gl2d subplots to the "strict" bundle.

To test it within dashboard after checking out the branch

npm ci
npm run strict

@plotly/plotly_js

@archmoj
temp root install gl-shader
f6e1b2c
@archmoj
link to gl-shader with function constructors removed
e0fa241
@archmoj
link to robust-orientation with function constructors removed
0e1bce4
@archmoj
temp root install robust-in-sphere
cab3978
@archmoj
link to robust-in-sphere with function constructors removed
d289dbe
@archmoj
temp root install robust-linear-solve
2d7e2af
@archmoj
link to robust-linear-solve with function constructors removed
a97861b
@archmoj
temp root install robust-determinant
2a8931e
@archmoj
link to robust-determinant with function constructors removed
088f426
@archmoj
temp root install box-intersect
2b6b3c5
@archmoj
link to box-intersect with function constructors removed
622b9bf
@archmoj
root install vectorize-text 3.2.2 - say goodbye to binary-search-boun…
64916b7 
…ds v1
@archmoj
install newly published dependencies
d4d3c1e
@archmoj
reinstall gl-plot3d so that binary-search-bounds deduped at v2.0.5
6d72c63
@archmoj
root install surface-nets
d661508
@archmoj
link to surface-nets with function constructors removed
171923a
@archmoj
temp root install simplicial-complex-contour
ef73b89
@archmoj
link to simplicial-complex-contour with function constructors removed
b976bf2
@archmoj
temp root install incremental-convex-hull
2bf1cdb
@archmoj
link to incremental-convex-hull with function constructors removed
180f117
@archmoj
link to ndarray with function constructors removed
5085349
@archmoj
temp root install ndarray-ops
b68e28d
@archmoj
link to ndarray-ops with function constructors removed
c3429a4
@archmoj
temp root install 3d-view
ed05457
@archmoj
link to 3d-view with function constructors removed
c7139b3
@archmoj
temp root install ndarray-gradient
fd3502f
@archmoj
link to ndarray-gradient with fixed cache
0265592
@archmoj
link to ndarray-gradient with cached functions for gl-surface3d
4318a9b
@archmoj
temp root install zero-crossings
c382a01
@archmoj
link to zero-crossings which no longer depends on cwise-compiler
932e60c
archmoj
archmoj commented Aug 12, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Aug 12, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Aug 12, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Aug 12, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Aug 12, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Sep 1, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Sep 1, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Sep 1, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Sep 1, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Sep 1, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Sep 1, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
archmoj
archmoj commented Sep 1, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@archmoj archmoj added this to the v2.5.0 milestone Sep 1, 2021
archmoj
archmoj commented Sep 2, 2021
View reviewed changes
package.json
@@ -152,7 +168,7 @@
"deep-equal": "^2.0.5",
"derequire": "^2.1.1",
"ecstatic": "^4.1.4",
"eslint": "^7.32.0",
"eslint": "git://github.com/archmoj/eslint#083ad40001b45ad06b07ef0449b6f06e5c9bb099",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint/eslint#14860

alexcjohnson
alexcjohnson reviewed Sep 2, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
alexcjohnson
alexcjohnson approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I'm not going to go through all the new code you've added in all the sub-packages... the tests pass so I'm happy :) 💃

@archmoj
Copy link
Contributor Author

archmoj commented Sep 2, 2021

Changes to the bundle sizes:

  • Red: before
  • Green: after

sizes

This could be reduced in follow up PR(s) by removing unused dimensions e.g. iso-surface generation in surface-nets and other modules.

@archmoj archmoj merged commit d3b1345 into master Sep 2, 2021
@archmoj archmoj deleted the gl3d-without-function-constructors branch September 2, 2021 20:35
@archmoj archmoj mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
status: reviewable type: feature
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@archmoj @alexcjohnson