Merge pull request #6443 from plotly/sync-tickmode-fix-noci

Avoid extra redraw calls when updating axes with `tickmode` other than sync
plotly · Jan 19, 2023 · fad8fde · fad8fde
2 parents 360213e + 0828681
commit fad8fde
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/draftlogs/6356_add.md b/draftlogs/6356_add.md
@@ -1 +1 @@
-- Add `sync` tickmode option [[#6356](https://github.com/plotly/plotly.js/pull/6356)]
+- Add `sync` tickmode option [[#6356](https://github.com/plotly/plotly.js/pull/6356), [#6443](https://github.com/plotly/plotly.js/pull/6443)]
diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js
@@ -729,7 +729,9 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
 
         function pushActiveAxIdsSynced(axList, axisType) {
             for(i = 0; i < axList.length; i++) {
-                if(!axList[i].fixedrange && axList[i][axisType]) {activeAxIds.push(axList[i][axisType]._id);}
+                var axListI = axList[i];
+                var axListIType = axListI[axisType];
+                if(!axListI.fixedrange && axListIType.tickmode === 'sync') activeAxIds.push(axListIType._id);
             }
         }