Enable CI platforms to build Linux, Windows and OS X releases #63
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,12 +13,17 @@ workflows: | |
| jobs: | ||
| - test-node-v6 | ||
| - test-node-v8 | ||
| - docker-build: | ||
| requires: | ||
| - test-node-v6 | ||
| - test-node-v8 | ||
| - docker-push: | ||
| requires: | ||
| - docker-build | ||
| - electron-pack-and-release: | ||
| requires: | ||
| - test-node-v6 | ||
| - test-node-v8 | ||
|
|
||
| version: 2 | ||
| jobs: | ||
|
|
@@ -31,11 +36,22 @@ jobs: | |
| command: | | ||
| echo "npm: $(npm --version)" | ||
| echo "node: $(node --version)" | ||
| - restore_cache: | ||
| key: v1-source-{{ .Branch }}-{{ .Revision }} | ||
| keys: | ||
| - v1-source-{{ .Branch }}- | ||
| - v1-source- | ||
| - checkout | ||
|
There was a problem hiding this comment. In Falcon, we also keep a cache for There was a problem hiding this comment. Okay, @n-riesco, how about now?: https://circleci.com/gh/plotly/image-exporter/1175#config/containers/0 |
||
| - save_cache: | ||
| key: v1-source-{{ .Branch }}-{{ .Revision }} | ||
| paths: | ||
| - ".git" | ||
| - restore_cache: | ||
| key: v2-npm-{{ checksum "package-lock.json" }} | ||
| keys: | ||
| - v2-npm- | ||
| - run: node --version | ||
| - run: npm --version | ||
| - run: | ||
| name: Install deps | ||
| command: | | ||
|
|
@@ -44,15 +60,15 @@ jobs: | |
| - run: | ||
| name: List deps | ||
| command: | | ||
| npm list | ||
| pdftops -v | ||
| - save_cache: | ||
| key: v2-npm-{{ checksum "package-lock.json" }} | ||
| paths: | ||
| - node_modules | ||
| - run: | ||
| name: Test | ||
| command: npm run test | ||
| - run: | ||
| name: Coverage | ||
| command: npm run coverage | ||
|
|
@@ -62,38 +78,50 @@ jobs: | |
| test-node-v6: | ||
| <<: *base | ||
| docker: | ||
| - image: circleci/node:6-browsers | ||
|
|
||
| test-node-v8: | ||
| <<: *base | ||
| docker: | ||
| - image: circleci/node:8-browsers | ||
|
There was a problem hiding this comment. @etpinard My rationale, is that this software is made to run on many people's personal computers, with diverse versioning profiles, rather than servers for which Plotly has complete control to use only one very precise version. I am happy to revert this change if Plotly wishes me to do so, otherwise I vote to keep this change. There was a problem hiding this comment. I prefer locking down the image versions. I don't think this project is likely to break from one minor release of node.js to another. There was a problem hiding this comment. Okay, I have made this change. How's it look? |
||
|
|
||
| docker-build: | ||
| docker: | ||
| - image: circleci/node:8-browsers | ||
| steps: | ||
| - setup_remote_docker: | ||
| reusable: true | ||
|
|
||
| - restore_cache: | ||
| key: v1-source-{{ .Branch }}-{{ .Revision }} | ||
| keys: | ||
| - v1-source-{{ .Branch }}- | ||
| - v1-source- | ||
| - checkout | ||
| - save_cache: | ||
| key: v1-source-{{ .Branch }}-{{ .Revision }} | ||
| paths: | ||
| - ".git" | ||
| - restore_cache: | ||
| keys: | ||
| - v2-npm-{{ checksum "package-lock.json" }} | ||
| - run: | ||
| name: Build Docker image | ||
| command: | | ||
| docker build -f deployment/Dockerfile -t quay.io/plotly/image-exporter:$CIRCLE_SHA1 . | ||
| - run: | ||
| name: Smoke test Docker image | ||
| command: | | ||
| docker run -d -p 9091:9091/tcp --name imageserver quay.io/plotly/image-exporter:$CIRCLE_SHA1 | ||
| docker run --network container:imageserver quay.io/plotly/wget wget --retry-connrefused --waitretry=1 -t 60 -O /dev/null --progress=dot http://localhost:9091/ping | ||
| - save_cache: | ||
| paths: | ||
| - node_modules | ||
| key: v2-npm-{{ checksum "package-lock.json" }} | ||
|
|
||
| docker-push: | ||
| docker: | ||
| - image: circleci/node:8-browsers | ||
|
|
||
| steps: | ||
| - setup_remote_docker: | ||
|
|
@@ -106,3 +134,37 @@ jobs: | |
| docker tag quay.io/plotly/image-exporter:$CIRCLE_SHA1 quay.io/plotly/image-exporter:$CIRCLE_BRANCH | ||
| docker push quay.io/plotly/image-exporter:$CIRCLE_SHA1 | ||
| docker push quay.io/plotly/image-exporter:$CIRCLE_BRANCH | ||
|
|
||
| electron-pack-and-release: | ||
| docker: | ||
| - image: circleci/node:8-browsers | ||
| steps: | ||
|
There was a problem hiding this comment. I'd add the same steps to save and restore caches for There was a problem hiding this comment. @n-riesco good call. Okay, I have added these caches: https://circleci.com/gh/plotly/image-exporter/1201#config/containers/0. I ran the builds twice after this change, to ensure it worked with and without a primed cache—all good. What do you think? There was a problem hiding this comment. @JamesCropcho In Falcon we use 2 caches: There was a problem hiding this comment. You are correct, @n-riesco . I have changed the CircleCI caching strategy as per your recommendations, and tested with fresh and primed caches. |
||
| - restore_cache: | ||
| key: v1-source-{{ .Branch }}-{{ .Revision }} | ||
| keys: | ||
| - v1-source-{{ .Branch }}- | ||
| - v1-source- | ||
| - checkout | ||
| - save_cache: | ||
| key: v1-source-{{ .Branch }}-{{ .Revision }} | ||
| paths: | ||
| - ".git" | ||
| - restore_cache: | ||
| key: v2-npm-{{ checksum "package-lock.json" }} | ||
| keys: | ||
| - v2-npm- | ||
| - run: node --version | ||
| - run: npm --version | ||
| - run: npm install | ||
| - run: | ||
| name: Electron-Builder pack | ||
| command: npm run pack | ||
| - save_cache: | ||
| key: v2-npm-{{ checksum "package-lock.json" }} | ||
| paths: | ||
| - node_modules | ||
| - run: mkdir artifacts | ||
| - run: mv release/*.yml artifacts || true | ||
| - run: mv release/image-exporter* artifacts | ||
| - store_artifacts: | ||
| path: artifacts | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,8 @@ coverage | |
| .nyc_output | ||
|
|
||
| /build | ||
| /release | ||
|
|
||
| deployment/*.retry | ||
|
|
||
| /yarn-error.log | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| matrix: | ||
| include: | ||
| - os: osx | ||
| osx_image: xcode9.0 | ||
| language: node_js | ||
| node_js: "8" | ||
| env: | ||
| - ELECTRON_CACHE=$HOME/.cache/electron | ||
| - ELECTRON_BUILDER_CACHE=$HOME/.cache/electron-builder | ||
|
|
||
| cache: | ||
| directories: | ||
| - node_modules | ||
| - $HOME/.cache/electron | ||
| - $HOME/.cache/electron-builder | ||
|
|
||
| install: | ||
| - npm install | ||
|
|
||
| script: | ||
| - npm run pack | ||
| - zip mac-release.zip release/Plotly\ Graph\ Exporter* | ||
|
|
||
| before_cache: | ||
| - rm -rf $HOME/.cache/electron-builder/wine | ||
|
|
||
| addons: | ||
| artifacts: | ||
| s3_region: us-east-1 | ||
| paths: mac-release.zip | ||
| debug: true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| version: 0.1.{build} | ||
|
|
||
| environment: | ||
| matrix: | ||
| - nodejs_version: 8 | ||
|
|
||
| platform: | ||
| - x64 | ||
|
|
||
| #services: | ||
|
|
||
| cache: | ||
| - node_modules | ||
| - '%LOCALAPPDATA%\electron\Cache' | ||
| - '%LOCALAPPDATA%\electron-builder\cache' | ||
|
|
||
| init: | ||
| - git config --global core.autocrlf input | ||
|
|
||
| install: | ||
| - ps: Install-Product node $env:nodejs_version $env:platform | ||
|
|
||
| build_script: | ||
| - npm run pack | ||
|
|
||
| after_build: | ||
| - 7z a release.zip release/latest.yml release/*.exe | ||
|
|
||
| artifacts: | ||
| - path: release.zip | ||
| name: release | ||
|
|
||
| test: off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job didn't run:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@n-riesco It appears to me that "electron-pack-and-release" is running: https://circleci.com/gh/plotly/image-exporter/tree/test-builds-across-travis-circle-appveyor
(See #1124 for example.)
Please pardon, am I missing something simple?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesCropcho For some reason, github doesn't show the build (as seen on the above screenshot). Since circleCI runs the job, then this isn't an issue.