Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 32-bit Arm gn file #81

Closed
wants to merge 1 commit into from
Closed

Conversation

tapiralec
Copy link
Contributor

It seems like the docker images can compile for Arm 32-bit now. I needed this to run on a headless RaspberryPi, and it appears to work just fine after installing libnss3.

I also updated the README.md to refer to the current docker image (jonmmease/chromium-builder:0.9) that's pulled in the build_kaleido script as of Commit 37e6ec4

Let me know if you would prefer these two changes to be two separate PRs. Thanks for taking the time to make it easy to build from source!

It seems like the docker images can compile for Arm 32-bit now. I needed this to run on a headless RaspberryPi, and it appears to work just fine after installing libnss3.

I also updated the README.md to refer to the current docker image (jonmmease/chromium-builder:0.9) that's pulled in the build_kaleido script as of Commit plotly@37e6ec4
@tapiralec
Copy link
Contributor Author

Oh, sorry, I also meant to tie in issue #7 - it was closed with the comment that it was preferable to have separate issues on a per-architecture basis, but I didn't see an open issue for 32-bit Arm.

@jonmmease
Copy link
Collaborator

Thanks for working on this @tapiralec! Glad to hear it wasn't too hard to get things working for you. I'll try things out soon, and look at adding this to the CI build.

Are you using this for Python? Wondering if there's any work needed to get the PyPI platform tag working.

@tapiralec
Copy link
Contributor Author

Yeah, I'm using it on python3.9.2 currently. I'm not familiar with how to set up things for PyPI, but I will say that the wheel installed fine from pip.

@jonmmease jonmmease mentioned this pull request Apr 1, 2021
@jonmmease
Copy link
Collaborator

Continuing over in #82 to work on the CircleCI build

@jonmmease jonmmease closed this Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants