Remove @testing-library/cypress dep, as it breaks builds if the inter… #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal cypress release is different than the one in this package
|
@pnicolli we've found this issue... :( If you update the cypress to a version different than the one in @testing-library/cypress it breaks for new machines, as it tries to download both at the same time! ... we can put it back when they fix the issue |
|
Oh wow, didn't know about it. Sure, it makes sense to remove this part of testing-library. |
sneridagh
added a commit
that referenced
this pull request
Nov 29, 2019
* master: Fix to a good know digest (#1022) Back to development Release 4.0.0-alpha.15 Export the resetContent action (#1017) Remove @testing-library/cypress dep, as it breaks builds if the inter… (#1018) Minorcssfixes (#1016) Back to development Release 4.0.0-alpha.14 More on upgrading to a14 Proper config for stylelint-prettier integration, add husky integration and scripts for stylelint, review rules (#1012) Update outdated yarn.lock. Upgrade cypress to 3.6.1.
sneridagh
added a commit
that referenced
this pull request
Dec 2, 2019
* master: (53 commits) Fix small CSS issues in Blocks (#1023) Forked `react-helmet` since it seems unmaintained. Now it's a Named import in helpers (#1025) Solvepeerdependencies (#1026) Fix to a good know digest (#1022) Back to development Release 4.0.0-alpha.15 Export the resetContent action (#1017) Remove @testing-library/cypress dep, as it breaks builds if the inter… (#1018) Minorcssfixes (#1016) Back to development Release 4.0.0-alpha.14 More on upgrading to a14 Proper config for stylelint-prettier integration, add husky integration and scripts for stylelint, review rules (#1012) Update outdated yarn.lock. Back to development Release 4.0.0-alpha.13 Upgrade cypress to 3.6.1. Upgrade react and react-dom to 16.12.0 (#1008) Upgrade autoprefixer, remove deprecated browsers option, move to browserlist in package.json (#1007) Back to development ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nal cypress release is different than the one in this package