Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Teaser blocks dynamic #1788

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make Teaser blocks dynamic #1788

wants to merge 5 commits into from

Conversation

pbauer
Copy link
Sponsor Member

@pbauer pbauer commented May 16, 2024

PLIP: plone/volto#6023
Depends on plone/volto#6024 but should not break anything without it.

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link

netlify bot commented May 16, 2024

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit faac7e4
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/66471ffc9b39f90008a5a2d9

@sneridagh
Copy link
Member

@jenkins-plone-org please run jobs

if not url:
return
brain = None
match = re.search("resolveuid/([^/]+)", url)
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint: a global re.compile before save CPU-cycles.

@sneridagh
Copy link
Member

@pbauer could you take care of Jens suggestion?
@davisagli could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants