Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black=22.3.0 #1427

Merged
merged 2 commits into from May 13, 2022
Merged

Black=22.3.0 #1427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6495493
Black=22.3.0
tisto May 12, 2022
9b182b7
flake8 = 4.0.1
tisto May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/flake8.yml
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ jobs:

# install flake8
- name: install flake8
run: pip install flake8
run: pip install flake8==$(awk '/^flake8 =/{print $NF}' versions.cfg)

# run black
- name: run flake8
Expand Down
3 changes: 2 additions & 1 deletion versions.cfg
View file
Open in desktop
Expand Up @@ -5,8 +5,9 @@ zc.buildout =
plone.restapi =

# code analysis
black = 20.8b1
black = 22.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With version 22.3.0 of black, no need to pin click = 8.0.4. See psf/black#2966

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to pin the black in a constraints.txt? black is not used in buildout.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Thanks! I don't like spreading pins across files and versions.cfg is something that almost all plone packages have, if they follow best practices.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, on second thought we are about to move away from buildout in the long run, so it might be worth to consider. Will look into it...

click = 8.0.4
flake8 = 4.0.1

# Error: The requirement ('virtualenv>=20.0.35') is not allowed by your [versions] constraint (20.0.26)
virtualenv = 20.0.35
Expand Down