Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: multi arch builds #504

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

smuda
Copy link
Contributor

@smuda smuda commented May 7, 2024

Closes #489

docker buildx creates a little more modern docker images than docker build (read OCI) so a slight incompatibility may occur. buiildx is also a bit slow, in my test on github it took over 20 minuter. Perhaps it would be better to switch to ko as a build system?

But I haven't done that now.

@smuda smuda force-pushed the feature/multi-arch-builds branch from 2219b7b to 7baa16e Compare May 8, 2024 04:00
@smuda smuda force-pushed the feature/multi-arch-builds branch from 7baa16e to e53f84c Compare May 8, 2024 04:22
Copy link
Collaborator

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks for addressing this! LGTM

@jalseth jalseth merged commit f2a0abd into plexsystems:main May 13, 2024
11 checks passed
@smuda smuda deleted the feature/multi-arch-builds branch May 19, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No arm64 docker image for konstraint
2 participants