Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.x] Fix jjwt compatibility to allow upgrades #12624

Merged
merged 1 commit into from May 8, 2024

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented May 8, 2024

The previous pull request did not handle the creation of new cookies 😢 This PR should fix this now.

@mkurz
Copy link
Member Author

mkurz commented May 8, 2024

@Mergifyio backport 2.9.x

@mkurz mkurz added this to the 2.9.4 / 3.0.4 milestone May 8, 2024
Copy link
Contributor

mergify bot commented May 8, 2024

backport 2.9.x

✅ Backports have been created

@mkurz mkurz merged commit 8d9ba21 into playframework:3.0.x May 8, 2024
25 checks passed
@mkurz mkurz deleted the fix-jjwt-compatibility branch May 8, 2024 08:50
@PromanSEW
Copy link
Contributor

PromanSEW commented May 8, 2024

In these cases should be test sbt project with upgraded dependency, isn't it?

mergify bot added a commit that referenced this pull request May 8, 2024
[2.9.x] Fix jjwt compatibility to allow upgrades (backport #12624) by @mkurz
@mkurz
Copy link
Member Author

mkurz commented May 8, 2024

In these cases should be test sbt project with upgraded dependency, doesn't it?

We could add a scripted test for the 3.0.x and 2.9.x branch, yes. IMHO, making this jjwt upgrade work is more a hack right now until the a new Play release upgrades it the correct way.

@mkurz
Copy link
Member Author

mkurz commented May 8, 2024

In these cases should be test sbt project with upgraded dependency, doesn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants