Remove deprecated constantTimeEquals methods from CSRFTokenSigner
#12519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
changed the title
CSRFTokenSigner methods deprecated by Play v2.6
rtyley
changed the title
CSRFTokenSigner methods deprecated by Play v2.6constantTimeEquals methods from CSRFTokenSigner
mkurz
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Thanks! The MiMa checks are failing. Can you please add the three needed MiMa filters to the already existing ones (appending)? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes deprecated
constantTimeEquals()methods on the Scala implementation ofCSRFTokenSigner- these methods were deprecated with #6429 back in August 2016 with Play v2.6.This PR does break binary compatibility (hence the failing test), because it's removing deprecated methods/objects.
There are no
constantTimeEquals()or deprecated methods on the Javaplay.libs.crypto.CSRFTokenSignerimplementation, so no methods changes are occurring there.Background Context
I encountered these deprecated methods while addressing guardian/play-secret-rotation#445 and thought they may as well be removed.
I also opened this PR to see how receptive you'd be to PRs that break binary compatibility, because I'm interested in #12520!