Fix duplicate assets and multiple pipeline runs #12483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… runs and duplicated files in dist packages
mkurz
changed the title
|
hmm... there is a scripted test failing, also maybe #12484 play a role here and should be looked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an exhaustive scripted test.
In the first commit the scripted tests test for the wrong behaviour (currently present until Play 3.0.2).
In the second commit I add the keys to fix the problem and also adjust the scripte test, so you can nicely see what's changed (which files will not be packaged anymore and also that the asset pipeline runs correctly now).