Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson 2.15.4 (was 2.14.3) #12440

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Feb 29, 2024

Step by step.

Akka bumped already, seems everything went smoothly:

Upgrade to 2.16 will be done in:

@PromanSEW
Copy link
Contributor

@mkurz
Copy link
Member Author

mkurz commented Feb 29, 2024

Will investigate later...

play.api.data.FormUtilsSpec

[info] FormUtils.fromJson should
...
[error]   ! not stack overflow when converting heavily nested arrays (15 ms)
[error]    com.fasterxml.jackson.core.exc.StreamConstraintsException: Depth (1001) exceeds the maximum allowed nesting depth (1000) (StreamReadConstraints.java:261)
[error] com.fasterxml.jackson.core.StreamReadConstraints.validateNestingDepth(StreamReadConstraints.java:261)
[error] com.fasterxml.jackson.core.base.ParserBase.createChildArrayContext(ParserBase.java:1320)
[error] com.fasterxml.jackson.core.json.ReaderBasedJsonParser.nextToken(ReaderBasedJsonParser.java:755)
[error] play.api.libs.json.jackson.JsValueDeserializer.deserialize(JacksonJson.scala:240)
[error] play.api.libs.json.jackson.JsValueDeserializer.deserialize(JacksonJson.scala:158)
[error] play.api.libs.json.jackson.JsValueDeserializer.deserialize(JacksonJson.scala:153)
[error] com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:323)
[error] com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:4801)
[error] com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2974)
[error] play.api.libs.json.jackson.JacksonJson.parseJsValue(JacksonJson.scala:296)
[error] play.api.libs.json.StaticBinding$.parseJsValue(StaticBinding.scala:17)
[error] play.api.libs.json.Json$.parse(Json.scala:175)
[error] play.api.data.FormUtilsSpec.$anonfun$new$5(FormUtilsSpec.scala:60)
play.it.http.parsing.JacksonJsonBodyParserSpec

[info] JacksonJsonBodyParserSpec
[info] The JSON body parser should
...
[error]   ! parse very deep JSON bodies (62 ms)
[error]    java.util.NoSuchElementException: No value present (JacksonJsonBodyParserSpec.scala:76)
[error] play.it.http.parsing.JacksonJsonBodyParserSpec$$anon$3.running(JacksonJsonBodyParserSpec.scala:76)
[error] play.api.test.AroundHelper.$anonfun$around$1(Specs.scala:78)
[error] play.api.test.WithApplication.$anonfun$wrap$2(Specs.scala:133)
[error] play.api.test.PlayRunners.$anonfun$running$2(Helpers.scala:86)
[error] play.api.test.PlayRunners.runSynchronized(Helpers.scala:61)
[error] play.api.test.PlayRunners.runSynchronized$(Helpers.scala:55)
[error] play.api.test.Helpers$.runSynchronized(Helpers.scala:788)
[error] play.api.test.PlayRunners.running(Helpers.scala:84)
[error] play.api.test.PlayRunners.running$(Helpers.scala:82)
[error] play.api.test.Helpers$.running(Helpers.scala:788)
[error] play.api.test.WithApplication.wrap(Specs.scala:133)
[error] play.api.test.AroundHelper.around(Specs.scala:78)
[error] play.api.test.AroundHelper.delayedInit(Specs.scala:24)
[error] play.api.test.AroundHelper.<init>(Specs.scala:24)
[error] play.api.test.WithApplication.<init>(Specs.scala:124)
[error] play.it.http.parsing.JacksonJsonBodyParserSpec$$anon$3.<init>(JacksonJsonBodyParserSpec.scala:72)
[error] play.it.http.parsing.JacksonJsonBodyParserSpec.$anonfun$new$4(JacksonJsonBodyParserSpec.scala:72)

@mkurz
Copy link
Member Author

mkurz commented May 7, 2024

Also nightly test fail because they use pekko snapshots which already upgraded jackson:
https://github.com/playframework/playframework/actions/workflows/build-test.yml?query=event%3Aschedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants