Migrate from Hamcrest/FEST-Assert to AssertJ (test sources) #12184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihostage
force-pushed
the
assertj-part1
branch
2 times, most recently
from
05a9f7d
to
f86cd73
Compare
ihostage
changed the title
ihostage
force-pushed
the
assertj-part1
branch
from
f86cd73
to
aa82ce2
Compare
ihostage
changed the title
|
@Mergifyio rebase |
ihostage
force-pushed
the
assertj-part1
branch
from
aa82ce2
to
f29d996
Compare
✅ Branch has been successfully rebased |
|
@ihostage Looking at this very soon. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
mkurz
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
OK, after reading through
I get it.
Hamcrest is dead more or less:
- https://github.com/hamcrest/JavaHamcrest/commits/master/
- https://github.com/hamcrest/JavaHamcrest/tags (almost 5 years no release)
- https://groups.google.com/g/hamcrest-dev/c/lYcF3lz8JDQ
- Inquiry about Project Activity and Future Plans hamcrest/JavaHamcrest#405
And I don't know how we still use a 13 year old outdated library 😉
- https://repo1.maven.org/maven2/org/easytesting/fest-assert/1.4/
- https://github.com/easytesting/fest-assert-core
Seems like assertj is the way to got now.
mkurz
added
the
not backported to 2.9.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a first small step for
I'm still thinking we should migrate to AssertJ firstly instead of rewrite assertion expressions twice (Hamcrest -> JUnit5 -> AssertJ).
In this part I remove using Hamcrest in sources. The second part will be related to documentation.